[Mlir-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

Chris B llvmlistbot at llvm.org
Mon Mar 25 16:42:51 PDT 2024


llvm-beanz wrote:

> This ^ seems a bit problematic to me, though (where the contents of the repo isn't representative of the bits we want - but perhaps it's schrodinger's line endings & it doesn't matter if it's always checked out as crlf - though if we one day converted to another source control system, would that be a problem? are there some things that examine the underlying/"real" repo contents?) - what would be the cost to using `eol=input` as you've done for the mixed line ending case? below \=

The argument I would have in favor of an explicit value rather than `eol=input` is that it at least gives us a source of truth in the `.gitattributes` as to what type of line ending the file is supposed to have.

I don't have a strong feeling one way or another. I just want `autocrlf=true` to work reliably on all platforms.


https://github.com/llvm/llvm-project/pull/86318


More information about the Mlir-commits mailing list