[Mlir-commits] [mlir] [mlir][test] Make SME e2e tests require an emulator (PR #86489)

Mehdi Amini llvmlistbot at llvm.org
Mon Mar 25 13:24:44 PDT 2024


================
@@ -4,6 +4,10 @@ import sys
 if not config.mlir_run_arm_sme_tests:
     config.unsupported = True
 
+# With no hardware available, ArmSME tests require emulation.
+if not config.arm_emulator_executable:
+    config.unsupported = True
+
----------------
joker-eph wrote:

I would rather have this be an error: we shouldn't allow `-DMLIR_RUN_ARM_SME_TESTS=On` without the emulator. 
Here the user will see  `ninja check-mlir`  complete successfully but ignoring these tests despite the CMake flag enabling them.

https://github.com/llvm/llvm-project/pull/86489


More information about the Mlir-commits mailing list