[Mlir-commits] [mlir] [mlir] Declare promised interfaces for all dialects (PR #78368)

Stella Laurenzo llvmlistbot at llvm.org
Mon Mar 18 13:37:03 PDT 2024


stellaraccident wrote:

> This is all a fallout from adding "external interfaces" to quickly actually.

I agree with that. I think we need to take a pause and evaluate. Once added, these things live for a very long time, and I think we owe it to ourselves if we are feeling discomfort about the feature direction to step back and make sure we've got a good view of it.

This isn't a knock on anyone: these things can be really tricky to get right, and they can balloon far outside of the original conceived scope. We can stop the line on that and discuss vs just moving forward. Speaking again just for myself, I'd be willing/able to give it more principled thought but can't get my brain around it mid flight like this (without a pause/discussion).

https://github.com/llvm/llvm-project/pull/78368


More information about the Mlir-commits mailing list