[Mlir-commits] [mlir] [MLIR] Add missing MLIRFuncDialect dep to MLIRAffineAnalysis (PR #84555)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Fri Mar 8 11:39:52 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-affine

Author: Thomas Preud'homme (RoboTux)

<details>
<summary>Changes</summary>

Note: lib/libMLIRAffineAnalysis.a does build successfully in Ninja
without this patch. The missing dependency was discovered when
converting the CMake build system to bob which put output for each
target in their own build directory. A missing dependency will thus fail
because even though the target dep might be built indirectly, the
path to the dep will not be added to the include path and files are not
found when building the target.


---
Full diff: https://github.com/llvm/llvm-project/pull/84555.diff


1 Files Affected:

- (modified) mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt (+1) 


``````````diff
diff --git a/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt b/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
index 61e49b0da8b2d0..3210d88c260035 100644
--- a/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
+++ b/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
@@ -14,6 +14,7 @@ add_mlir_dialect_library(MLIRAffineAnalysis
   MLIRCallInterfaces
   MLIRControlFlowInterfaces
   MLIRDialectUtils
+  MLIRFuncDialect
   MLIRInferTypeOpInterface
   MLIRSideEffectInterfaces
   MLIRPresburger

``````````

</details>


https://github.com/llvm/llvm-project/pull/84555


More information about the Mlir-commits mailing list