[Mlir-commits] [mlir] [mlir][Vector] Add support for masks in castAwayContractionLeadingOneDim (PR #81906)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Fri Mar 1 21:22:41 PST 2024


================
@@ -346,6 +349,12 @@ mlir::vector::castAwayContractionLeadingOneDim(vector::ContractionOp contractOp,
   // greedily to drop more.
   int64_t dropDim = 1;
 
+  if (isMasked) {
----------------
tanmaysachan wrote:

@dcaballe I was implementing a general purpose implementation of this, something like https://github.com/tanmaysachan/llvm-project/commit/242f9010fc0b3bf782abcf333b52e1c30121d252

Does this look okay to you? Can refactor for common code between the masked vs non-masked functions to be a function, and the pattern rewrites handle the entry points.

https://github.com/llvm/llvm-project/pull/81906


More information about the Mlir-commits mailing list