[Mlir-commits] [mlir] [mlir][EmitC] Add `verbatim` op (PR #79584)

Simon Camphausen llvmlistbot at llvm.org
Wed Jan 31 00:25:25 PST 2024


simon-camp wrote:

> This is very useful!
> 
> Out of curiosity, what makes the `trailing_semicolon` necessary? Isn't it easier to include `;` into the string itself, and the overcome the validation by adding a space at the end of the string?

Good suggestion, thank you.

I'm not sure I follow the validation part. The semicolon is now part of the attribute, so there is nothing to verify. Nonetheless this made me think of the implicit `\n` generated during emission, so this is now mentioned in the op description.

https://github.com/llvm/llvm-project/pull/79584


More information about the Mlir-commits mailing list