[Mlir-commits] [mlir] Fix TOSA FP16->INT16 CAST lowering (PR #79299)

Thomas Preud'homme llvmlistbot at llvm.org
Tue Jan 30 03:28:04 PST 2024


RoboTux wrote:

> I've just noticed one thing: this function is 500 lines long and this PR makes it longer. Does this have to be structured like this? I don't have any stake in this code, but I'm concerned about the maintainability.

I'm happy to fix that in a follow-up patch. Doing it in the same patch would make it harder to read IMO.

https://github.com/llvm/llvm-project/pull/79299


More information about the Mlir-commits mailing list