[Mlir-commits] [mlir] Fix duplicate mapping detection in gpu::setMappingAttr() (PR #77499)

Thomas Preud'homme llvmlistbot at llvm.org
Wed Jan 24 09:05:51 PST 2024


RoboTux wrote:

> I still have concerns about the testing: this diverges from how we test this kind of things in the project.
Should I remove the test then? As I said, the only caller to the function being fixed never triggers the wrong codepath so it can only be exercise by adding a new caller (which is what happens when adding the new unit test).

https://github.com/llvm/llvm-project/pull/77499


More information about the Mlir-commits mailing list