[Mlir-commits] [mlir] [mlir][ArmSME] Refactor ArmSMEToSCF to used shared loop-building helper (NFC) (PR #79172)

[Andrzej Warzyński]

https://github.com/banach-space approved this pull request.

Great clean-up Ben!

> This will make fixing a bug (next patch) a change to one place, rather than fixing three separate rewrites.
> 
> Note: TileLoadOpWithMaskAndPadZeroConversion has been merged into TileLoadOpConversion, since after this change those two rewrites were pretty much identical.

[nit] Your 1st point above is, IMHO, secondary. This patch makes a lot of sense regardless (i.e. on its own).  I find the 2nd point much more helpful - it helps me understand the rationale for a fairly non-trivial change (it would be hard to read that from the diff).

I've left a few minor requests, but otherwise LGTM, thanks!

https://github.com/llvm/llvm-project/pull/79172