[Mlir-commits] [mlir] [mlir][bufferization] Buffer deallocation: Make op preconditions stricter (PR #75127)

Aart Bik llvmlistbot at llvm.org
Fri Jan 19 09:42:53 PST 2024


================
@@ -48,6 +48,32 @@ static Value buildBoolValue(OpBuilder &builder, Location loc, bool value) {
 
 static bool isMemref(Value v) { return v.getType().isa<BaseMemRefType>(); }
 
+/// Return "true" if the given op is guaranteed to have no "Allocate" or "Free"
----------------
aartbik wrote:

This is super nit picky but the not before an or is always ambiguous (as in !Allocate or Free or !(Allocate or Free). I think you can avoid this by just saying to have neither Allocate nor Free ....

(and yes, I realize this is very nitpicky)

https://github.com/llvm/llvm-project/pull/75127


More information about the Mlir-commits mailing list