[Mlir-commits] [mlir] [mlir][llvm] Drop unreachable basic block during import (PR #78467)

Christian Ulmann llvmlistbot at llvm.org
Wed Jan 17 22:53:42 PST 2024


Dinistro wrote:

Turns out the MLIR also supports this. I was honestly not aware of this, and I fail to see any usecase for this, as the conversion framework doesn't touch unreachable blocks. It seems adding support for that might be possible by relaxing some assumptions, but the canonicalizer will afterwards just remove these unreachable blocks.

Thus, I'm in favor of taking the path of least resistance:
If this can be done easily, lets import these self-referencing operations, otherwise drop these constructs directly in the import, as done in this PR.  

https://github.com/llvm/llvm-project/pull/78467


More information about the Mlir-commits mailing list