[Mlir-commits] [mlir] Jf/promise interfaces (PR #78368)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Tue Jan 16 16:07:52 PST 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff e42edb5547618c172abe25914000bb61f5278c4c fcee97c95daea0687cbbfc2e9d40e9bec089bf21 -- mlir/lib/Dialect/Affine/IR/AffineOps.cpp mlir/lib/Dialect/Arith/IR/ArithDialect.cpp mlir/lib/Dialect/Bufferization/IR/BufferizationDialect.cpp mlir/lib/Dialect/ControlFlow/IR/ControlFlowOps.cpp mlir/lib/Dialect/GPU/IR/GPUDialect.cpp mlir/lib/Dialect/Linalg/IR/LinalgDialect.cpp mlir/lib/Dialect/MemRef/IR/MemRefDialect.cpp mlir/lib/Dialect/SCF/IR/SCF.cpp mlir/lib/Dialect/Shape/IR/Shape.cpp mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp mlir/lib/Dialect/Tensor/IR/TensorDialect.cpp mlir/lib/Dialect/Vector/IR/VectorOps.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Dialect/Affine/IR/AffineOps.cpp b/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
index 72ac9f30c2..84dc3b4dd6 100644
--- a/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
+++ b/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
@@ -8,7 +8,6 @@
#include "mlir/Dialect/Affine/IR/AffineOps.h"
#include "mlir/Dialect/Affine/IR/AffineValueMap.h"
-#include "mlir/Interfaces/ValueBoundsOpInterface.h"
#include "mlir/Dialect/MemRef/IR/MemRef.h"
#include "mlir/Dialect/UB/IR/UBOps.h"
#include "mlir/IR/AffineExprVisitor.h"
@@ -18,6 +17,7 @@
#include "mlir/IR/OpDefinition.h"
#include "mlir/IR/PatternMatch.h"
#include "mlir/Interfaces/ShapedOpInterfaces.h"
+#include "mlir/Interfaces/ValueBoundsOpInterface.h"
#include "mlir/Support/MathExtras.h"
#include "mlir/Transforms/InliningUtils.h"
#include "llvm/ADT/ScopeExit.h"
diff --git a/mlir/lib/Dialect/Arith/IR/ArithDialect.cpp b/mlir/lib/Dialect/Arith/IR/ArithDialect.cpp
index fea7ab05a6..d721ffa977 100644
--- a/mlir/lib/Dialect/Arith/IR/ArithDialect.cpp
+++ b/mlir/lib/Dialect/Arith/IR/ArithDialect.cpp
@@ -10,9 +10,9 @@
#include "mlir/Dialect/Bufferization/IR/BufferDeallocationOpInterface.h"
#include "mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h"
#include "mlir/Dialect/UB/IR/UBOps.h"
-#include "mlir/Interfaces/ValueBoundsOpInterface.h"
#include "mlir/IR/Builders.h"
#include "mlir/IR/DialectImplementation.h"
+#include "mlir/Interfaces/ValueBoundsOpInterface.h"
#include "mlir/Transforms/InliningUtils.h"
#include "llvm/ADT/TypeSwitch.h"
@@ -47,7 +47,8 @@ void arith::ArithDialect::initialize() {
#include "mlir/Dialect/Arith/IR/ArithOpsAttributes.cpp.inc"
>();
addInterfaces<ArithInlinerInterface>();
- declarePromisedInterface<SelectOp, bufferization::BufferDeallocationOpInterface>();
+ declarePromisedInterface<SelectOp,
+ bufferization::BufferDeallocationOpInterface>();
declarePromisedInterface<ConstantOp,
bufferization::BufferizableOpInterface>();
declarePromisedInterface<IndexCastOp,
diff --git a/mlir/lib/Dialect/Bufferization/IR/BufferizationDialect.cpp b/mlir/lib/Dialect/Bufferization/IR/BufferizationDialect.cpp
index d8a38868ac..c4d91ba72d 100644
--- a/mlir/lib/Dialect/Bufferization/IR/BufferizationDialect.cpp
+++ b/mlir/lib/Dialect/Bufferization/IR/BufferizationDialect.cpp
@@ -9,8 +9,8 @@
#include "mlir/Dialect/Affine/IR/AffineOps.h"
#include "mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h"
#include "mlir/Dialect/Bufferization/IR/Bufferization.h"
-#include "mlir/Dialect/MemRef/IR/MemRef.h"
#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/MemRef/IR/MemRef.h"
#include "mlir/Dialect/Tensor/IR/Tensor.h"
#include "mlir/Interfaces/FunctionInterfaces.h"
#include "mlir/Transforms/InliningUtils.h"
diff --git a/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp b/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
index 36a17ae823..eb7613b07e 100644
--- a/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
+++ b/mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
@@ -216,7 +216,8 @@ void GPUDialect::initialize() {
#include "mlir/Dialect/GPU/IR/GPUOpsAttributes.cpp.inc"
>();
addInterfaces<GPUInlinerInterface>();
- declarePromisedInterface<TerminatorOp, bufferization::BufferDeallocationOpInterface>();
+ declarePromisedInterface<TerminatorOp,
+ bufferization::BufferDeallocationOpInterface>();
}
static std::string getSparseHandleKeyword(SparseHandleKind kind) {
diff --git a/mlir/lib/Dialect/SCF/IR/SCF.cpp b/mlir/lib/Dialect/SCF/IR/SCF.cpp
index 2a861754a2..dd35509d17 100644
--- a/mlir/lib/Dialect/SCF/IR/SCF.cpp
+++ b/mlir/lib/Dialect/SCF/IR/SCF.cpp
@@ -15,12 +15,12 @@
#include "mlir/Dialect/MemRef/IR/MemRef.h"
#include "mlir/Dialect/SCF/IR/DeviceMappingInterface.h"
#include "mlir/Dialect/Tensor/IR/Tensor.h"
-#include "mlir/Interfaces/ValueBoundsOpInterface.h"
#include "mlir/IR/BuiltinAttributes.h"
#include "mlir/IR/IRMapping.h"
#include "mlir/IR/Matchers.h"
#include "mlir/IR/PatternMatch.h"
#include "mlir/Interfaces/FunctionInterfaces.h"
+#include "mlir/Interfaces/ValueBoundsOpInterface.h"
#include "mlir/Support/MathExtras.h"
#include "mlir/Transforms/InliningUtils.h"
#include "llvm/ADT/MapVector.h"
@@ -74,15 +74,21 @@ void SCFDialect::initialize() {
#include "mlir/Dialect/SCF/IR/SCFOps.cpp.inc"
>();
addInterfaces<SCFInlinerInterface>();
- declarePromisedInterface<InParallelOp, bufferization::BufferDeallocationOpInterface>();
- declarePromisedInterface<ReduceReturnOp, bufferization::BufferDeallocationOpInterface>();
- declarePromisedInterface<ConditionOp, bufferization::BufferizableOpInterface>();
- declarePromisedInterface<ExecuteRegionOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<InParallelOp,
+ bufferization::BufferDeallocationOpInterface>();
+ declarePromisedInterface<ReduceReturnOp,
+ bufferization::BufferDeallocationOpInterface>();
+ declarePromisedInterface<ConditionOp,
+ bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<ExecuteRegionOp,
+ bufferization::BufferizableOpInterface>();
declarePromisedInterface<ForOp, bufferization::BufferizableOpInterface>();
declarePromisedInterface<IfOp, bufferization::BufferizableOpInterface>();
- declarePromisedInterface<IndexSwitchOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<IndexSwitchOp,
+ bufferization::BufferizableOpInterface>();
declarePromisedInterface<ForallOp, bufferization::BufferizableOpInterface>();
- declarePromisedInterface<InParallelOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<InParallelOp,
+ bufferization::BufferizableOpInterface>();
declarePromisedInterface<WhileOp, bufferization::BufferizableOpInterface>();
declarePromisedInterface<YieldOp, bufferization::BufferizableOpInterface>();
declarePromisedInterface<ForOp, ValueBoundsOpInterface>();
diff --git a/mlir/lib/Dialect/Shape/IR/Shape.cpp b/mlir/lib/Dialect/Shape/IR/Shape.cpp
index 625fd0cd50..c26e0d4a11 100644
--- a/mlir/lib/Dialect/Shape/IR/Shape.cpp
+++ b/mlir/lib/Dialect/Shape/IR/Shape.cpp
@@ -144,8 +144,10 @@ void ShapeDialect::initialize() {
// still evolving it makes it simple to start with an unregistered ops and
// try different variants before actually defining the op.
allowUnknownOperations();
- declarePromisedInterface<AssumingOp, bufferization::BufferizableOpInterface>();
- declarePromisedInterface<AssumingYieldOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<AssumingOp,
+ bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<AssumingYieldOp,
+ bufferization::BufferizableOpInterface>();
}
Operation *ShapeDialect::materializeConstant(OpBuilder &builder,
diff --git a/mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp b/mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp
index 54f62d28ce..91c90c7ea4 100644
--- a/mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp
+++ b/mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp
@@ -1783,14 +1783,10 @@ void SparseTensorDialect::initialize() {
>();
declarePromisedInterface<ConcatenateOp,
bufferization::BufferizableOpInterface>();
- declarePromisedInterface<ConvertOp,
- bufferization::BufferizableOpInterface>();
- declarePromisedInterface<LoadOp,
- bufferization::BufferizableOpInterface>();
- declarePromisedInterface<NewOp,
- bufferization::BufferizableOpInterface>();
- declarePromisedInterface<InsertOp,
- bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<ConvertOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<LoadOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<NewOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<InsertOp, bufferization::BufferizableOpInterface>();
declarePromisedInterface<NumberOfEntriesOp,
bufferization::BufferizableOpInterface>();
declarePromisedInterface<AssembleOp,
diff --git a/mlir/lib/Dialect/Tensor/IR/TensorDialect.cpp b/mlir/lib/Dialect/Tensor/IR/TensorDialect.cpp
index ad7f288f62..8c215aae62 100644
--- a/mlir/lib/Dialect/Tensor/IR/TensorDialect.cpp
+++ b/mlir/lib/Dialect/Tensor/IR/TensorDialect.cpp
@@ -49,18 +49,25 @@ void TensorDialect::initialize() {
>();
addInterfaces<TensorInlinerInterface>();
declarePromisedInterface<CastOp, bufferization::BufferizableOpInterface>();
- declarePromisedInterface<CollapseShapeOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<CollapseShapeOp,
+ bufferization::BufferizableOpInterface>();
declarePromisedInterface<DimOp, bufferization::BufferizableOpInterface>();
declarePromisedInterface<EmptyOp, bufferization::BufferizableOpInterface>();
- declarePromisedInterface<ExpandShapeOp, bufferization::BufferizableOpInterface>();
- declarePromisedInterface<ExtractSliceOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<ExpandShapeOp,
+ bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<ExtractSliceOp,
+ bufferization::BufferizableOpInterface>();
declarePromisedInterface<ExtractOp, bufferization::BufferizableOpInterface>();
- declarePromisedInterface<FromElementsOp, bufferization::BufferizableOpInterface>();
- declarePromisedInterface<GenerateOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<FromElementsOp,
+ bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<GenerateOp,
+ bufferization::BufferizableOpInterface>();
declarePromisedInterface<InsertOp, bufferization::BufferizableOpInterface>();
- declarePromisedInterface<InsertSliceOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<InsertSliceOp,
+ bufferization::BufferizableOpInterface>();
declarePromisedInterface<PadOp, bufferization::BufferizableOpInterface>();
- declarePromisedInterface<ParallelInsertSliceOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<ParallelInsertSliceOp,
+ bufferization::BufferizableOpInterface>();
declarePromisedInterface<RankOp, bufferization::BufferizableOpInterface>();
declarePromisedInterface<ReshapeOp, bufferization::BufferizableOpInterface>();
declarePromisedInterface<SplatOp, bufferization::BufferizableOpInterface>();
diff --git a/mlir/lib/Dialect/Vector/IR/VectorOps.cpp b/mlir/lib/Dialect/Vector/IR/VectorOps.cpp
index 7f70da03d7..ad6e9709f2 100644
--- a/mlir/lib/Dialect/Vector/IR/VectorOps.cpp
+++ b/mlir/lib/Dialect/Vector/IR/VectorOps.cpp
@@ -381,10 +381,8 @@ void VectorDialect::initialize() {
bufferization::BufferizableOpInterface>();
declarePromisedInterface<TransferWriteOp,
bufferization::BufferizableOpInterface>();
- declarePromisedInterface<GatherOp,
- bufferization::BufferizableOpInterface>();
- declarePromisedInterface<MaskOp,
- bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<GatherOp, bufferization::BufferizableOpInterface>();
+ declarePromisedInterface<MaskOp, bufferization::BufferizableOpInterface>();
declarePromisedInterface<YieldOp, bufferization::BufferizableOpInterface>();
declarePromisedInterface<TransferReadOp, SubsetOpInterface>();
``````````
</details>
https://github.com/llvm/llvm-project/pull/78368
More information about the Mlir-commits
mailing list