[Mlir-commits] [mlir] 5afc4f3 - Revert "[mlir][arith][nfc] Fix typos (#77700)"

Ivan Butygin llvmlistbot at llvm.org
Thu Jan 11 15:07:59 PST 2024


Author: Ivan Butygin
Date: 2024-01-12T00:05:21+01:00
New Revision: 5afc4f3a5f6cc1bae4348bdd5f479451773d09a8

URL: https://github.com/llvm/llvm-project/commit/5afc4f3a5f6cc1bae4348bdd5f479451773d09a8
DIFF: https://github.com/llvm/llvm-project/commit/5afc4f3a5f6cc1bae4348bdd5f479451773d09a8.diff

LOG: Revert "[mlir][arith][nfc] Fix typos (#77700)"

Temporarily reverting as it broke python bindings

This reverts commit 9ed30012fb4f43de42ef2f265fe384d9d0b0edf2.

Added: 
    

Modified: 
    mlir/include/mlir/Conversion/ArithCommon/AttrToLLVMConverter.h
    mlir/include/mlir/Dialect/Arith/IR/ArithOpsInterfaces.td
    mlir/include/mlir/Dialect/LLVMIR/LLVMInterfaces.td
    mlir/lib/Conversion/ArithCommon/AttrToLLVMConverter.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Conversion/ArithCommon/AttrToLLVMConverter.h b/mlir/include/mlir/Conversion/ArithCommon/AttrToLLVMConverter.h
index 32d7979c32dfb2..0296ec969d0b32 100644
--- a/mlir/include/mlir/Conversion/ArithCommon/AttrToLLVMConverter.h
+++ b/mlir/include/mlir/Conversion/ArithCommon/AttrToLLVMConverter.h
@@ -29,12 +29,12 @@ convertArithFastMathAttrToLLVM(arith::FastMathFlagsAttr fmfAttr);
 
 /// Maps arithmetic overflow enum values to LLVM enum values.
 LLVM::IntegerOverflowFlags
-convertArithOverflowFlagsToLLVM(arith::IntegerOverflowFlags arithFlags);
+convertArithOveflowFlagsToLLVM(arith::IntegerOverflowFlags arithFlags);
 
 /// Creates an LLVM overflow attribute from a given arithmetic overflow
 /// attribute.
 LLVM::IntegerOverflowFlagsAttr
-convertArithOverflowAttrToLLVM(arith::IntegerOverflowFlagsAttr flagsAttr);
+convertArithOveflowAttrToLLVM(arith::IntegerOverflowFlagsAttr flagsAttr);
 
 // Attribute converter that populates a NamedAttrList by removing the fastmath
 // attribute from the source operation attributes, and replacing it with an
@@ -80,7 +80,7 @@ class AttrConvertOverflowToLLVM {
     if (arithAttr) {
       StringRef targetAttrName = TargetOp::getIntegerOverflowAttrName();
       convertedAttr.set(targetAttrName,
-                        convertArithOverflowAttrToLLVM(arithAttr));
+                        convertArithOveflowAttrToLLVM(arithAttr));
     }
   }
 

diff  --git a/mlir/include/mlir/Dialect/Arith/IR/ArithOpsInterfaces.td b/mlir/include/mlir/Dialect/Arith/IR/ArithOpsInterfaces.td
index 73a5d9c32ef205..e248422f84db84 100644
--- a/mlir/include/mlir/Dialect/Arith/IR/ArithOpsInterfaces.td
+++ b/mlir/include/mlir/Dialect/Arith/IR/ArithOpsInterfaces.td
@@ -93,7 +93,7 @@ def ArithIntegerOverflowFlagsInterface : OpInterface<"ArithIntegerOverflowFlagsI
       }]
       >,
     StaticInterfaceMethod<
-      /*desc=*/        [{Returns the name of the IntegerOverflowFlagsAttr attribute
+      /*desc=*/        [{Returns the name of the IntegerOveflowFlagsAttr attribute
                          for the operation}],
       /*returnType=*/  "StringRef",
       /*methodName=*/  "getIntegerOverflowAttrName",

diff  --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMInterfaces.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMInterfaces.td
index 3b2a132a881e4e..81589eaf5fd0a4 100644
--- a/mlir/include/mlir/Dialect/LLVMIR/LLVMInterfaces.td
+++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMInterfaces.td
@@ -92,7 +92,7 @@ def IntegerOverflowFlagsInterface : OpInterface<"IntegerOverflowFlagsInterface">
       }]
       >,
     StaticInterfaceMethod<
-      /*desc=*/        [{Returns the name of the IntegerOverflowFlagsAttr attribute
+      /*desc=*/        [{Returns the name of the IntegerOveflowFlagsAttr attribute
                          for the operation}],
       /*returnType=*/  "StringRef",
       /*methodName=*/  "getIntegerOverflowAttrName",

diff  --git a/mlir/lib/Conversion/ArithCommon/AttrToLLVMConverter.cpp b/mlir/lib/Conversion/ArithCommon/AttrToLLVMConverter.cpp
index dab064a3a954ec..3e9aef87b9ef1f 100644
--- a/mlir/lib/Conversion/ArithCommon/AttrToLLVMConverter.cpp
+++ b/mlir/lib/Conversion/ArithCommon/AttrToLLVMConverter.cpp
@@ -35,7 +35,7 @@ mlir::arith::convertArithFastMathAttrToLLVM(arith::FastMathFlagsAttr fmfAttr) {
       fmfAttr.getContext(), convertArithFastMathFlagsToLLVM(arithFMF));
 }
 
-LLVM::IntegerOverflowFlags mlir::arith::convertArithOverflowFlagsToLLVM(
+LLVM::IntegerOverflowFlags mlir::arith::convertArithOveflowFlagsToLLVM(
     arith::IntegerOverflowFlags arithFlags) {
   LLVM::IntegerOverflowFlags llvmFlags{};
   const std::pair<arith::IntegerOverflowFlags, LLVM::IntegerOverflowFlags>
@@ -49,9 +49,9 @@ LLVM::IntegerOverflowFlags mlir::arith::convertArithOverflowFlagsToLLVM(
   return llvmFlags;
 }
 
-LLVM::IntegerOverflowFlagsAttr mlir::arith::convertArithOverflowAttrToLLVM(
+LLVM::IntegerOverflowFlagsAttr mlir::arith::convertArithOveflowAttrToLLVM(
     arith::IntegerOverflowFlagsAttr flagsAttr) {
   arith::IntegerOverflowFlags arithFlags = flagsAttr.getValue();
   return LLVM::IntegerOverflowFlagsAttr::get(
-      flagsAttr.getContext(), convertArithOverflowFlagsToLLVM(arithFlags));
+      flagsAttr.getContext(), convertArithOveflowFlagsToLLVM(arithFlags));
 }


        


More information about the Mlir-commits mailing list