[Mlir-commits] [mlir] [MLIR][tensor] Improve `tensor.pack` verifier to catch more cases with unconditional runtime errors (PR #77217)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Jan 8 10:18:13 PST 2024


srcarroll wrote:

> Would it make sense to keep the padding behavior consistent between the static and dynamic behavior, having padding optional in both cases?

I dont think I understand this. Can you elaborate?  I thought that's what I was doing.  That is, in current `main`, when tile sizes are static we require padding when tile size doesn't divide input size.  The proprosed changes here extend this to the dynamic tile case, but require padding when output size doesn't divide input size.  That's consistent by my definition so obviously I'm missing something here.

https://github.com/llvm/llvm-project/pull/77217


More information about the Mlir-commits mailing list