[Mlir-commits] [mlir] [mlir][scf] Add simple LICM pattern for `scf.while` (PR #76370)

[Ivan Butygin]

Hardcode84 wrote:

> if you add this pattern to the LICM pass and run it before your conversion, would that solve your problem?

As was mentioned before in thread, canonicalizations can open new opportunities for CSE and LICM and vice-versa so you may need to run this sequence of passes arbitrary number of times. I can live without this pattern upstream and internally we have a facility to run sequence of passes until fixed point is reached. I can work on upstreaming it instead.

(how is this handled in llvm proper BTW?)

https://github.com/llvm/llvm-project/pull/76370