joker-eph wrote: Oh I see you add an ODS test, this is great! In general I like having TestDialect exercising it because it provides functional end-to-end running example, but it's not a requirement. Let me know and I'll merge this! https://github.com/llvm/llvm-project/pull/77061