[Mlir-commits] [mlir] [mlir] Exclude masked ops in VectorDropLeadUnitDim (PR #76468)

Andrzej WarzyƄski llvmlistbot at llvm.org
Thu Jan 4 11:10:06 PST 2024


https://github.com/banach-space approved this pull request.

Makes sense - this is consistent with the docs, thanks! LGTM

> I'm not quite sure of the complete solution for this issue. But the same problem might also happen to other vector transformations which require to insert ops before/after a maskable vector op. Any feedback will be very helpful : )

In my view, we should try to make sure that we use every opportunity possible to drop the unit dims at **higher levels** of abstraction  - to avoid the problem to begin with. Further down things become tricky.

https://github.com/llvm/llvm-project/pull/76468


More information about the Mlir-commits mailing list