[Mlir-commits] [mlir] [mlir] Declare promised interfaces for the ConvertToLLVM extension (PR #76341)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Tue Jan 2 01:09:00 PST 2024


================
@@ -6,6 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+#include "mlir/Conversion/ConvertToLLVM/ToLLVMInterface.h"
----------------
ftynse wrote:

Ideally, we shouldn't have something under `lib/Dialect` depend on something in `lib/Conversion`. I see there is precedent, so I can allow this for consistency. But this hits the design problem I'd like to ultimately address: where can we list promises.

https://github.com/llvm/llvm-project/pull/76341


More information about the Mlir-commits mailing list