[Mlir-commits] [mlir] [MLIR][OpenMP] Support basic materialization for `omp.private` ops (PR #81715)

Sergio Afonso llvmlistbot at llvm.org
Fri Feb 23 05:55:17 PST 2024


================
@@ -1000,11 +1011,52 @@ convertOmpWsLoop(Operation &opInst, llvm::IRBuilderBase &builder,
   return success();
 }
 
+/// A RAII class that on construction replaces the region arguments of the
+/// parallel op (which correspond to private variables) with the actual private
+/// variables they correspond to. This prepares the parallel op so that it
+/// matches what is expected by the OMPIRBuilder. Instead of editing the
+/// original op in-place, this function does the required changes to a cloned
+/// version which should then be erased by the caller.
----------------
skatrak wrote:

If I understood correctly, this class is intended to make in-place changes to the operation, and not a clone. I guess this part of the comment was copied from the previous approach.

https://github.com/llvm/llvm-project/pull/81715


More information about the Mlir-commits mailing list