[Mlir-commits] [mlir] [mlir] Declare promised interfaces for all dialects (PR #78368)

Stella Laurenzo llvmlistbot at llvm.org
Thu Feb 22 16:33:00 PST 2024


stellaraccident wrote:

> Where do we put this promise? Are we okay with having `#include "mlir/Dialects/Bufferization` from `mlir/IR`, for example?

Oof, that doesn't seem great. I have to admit I'm having a hard time wrapping my head around how this kind of two way dependency isn't going to be problematic as the system ages.

I feel like in prior lives, this would have been the job of some common registry of names and ids, at least for some definition of built-in things vs having the declarations organized into the directory structure of the "provider". That could just be a convention that upstream takes to keep the dependency graph sane, and downstreams could play a little looser if they want.

https://github.com/llvm/llvm-project/pull/78368


More information about the Mlir-commits mailing list