[Mlir-commits] [mlir] [mlir][Transforms][NFC] Turn op/block arg replacements into `IRRewrite`s (PR #81757)

Jacques Pienaar llvmlistbot at llvm.org
Thu Feb 22 13:44:59 PST 2024


================
@@ -957,6 +989,12 @@ struct ConversionPatternRewriterImpl : public RewriterBase::Listener {
   /// This allows the user to collect the match failure message.
   function_ref<void(Diagnostic &)> notifyCallback;
 
+  /// A set of pre-existing operations. When mode == OpConversionMode::Analysis,
+  /// this is populated with ops found to be legalizable to the target.
+  /// When mode == OpConversionMode::Partial, this is populated with ops found
+  /// *not* to be legalizable to the target.
----------------
jpienaar wrote:

Oof :) (nothing to change but yeah that could be confusing)

https://github.com/llvm/llvm-project/pull/81757


More information about the Mlir-commits mailing list