[Mlir-commits] [mlir] [mlir][Vector] Replace `vector.shuffle` with `vector.interleave` in vector narrow type emulation (PR #82550)

[Diego Caballero]

================
@@ -724,9 +724,8 @@ BitCastRewriter::BitCastRewriter(VectorType sourceVectorType,
 static LogicalResult commonConversionPrecondition(PatternRewriter &rewriter,
                                                   VectorType preconditionType,
                                                   Operation *op) {
-  if (!preconditionType || preconditionType.getRank() != 1 ||
-      preconditionType.isScalable())
-    return rewriter.notifyMatchFailure(op, "scalable or >1-D vector");
+  if (!preconditionType || preconditionType.isScalable())
+    return rewriter.notifyMatchFailure(op, "scalable vector");
----------------
dcaballe wrote:

I would say broader validation to make sure the backend is ok with the `i4` pieces but I currently don't have a large workload that compiles using scalable vectors.

https://github.com/llvm/llvm-project/pull/82550