[Mlir-commits] [mlir] replaces hardcoded attribute names in SPIRV dialect parsing code (PR #81552)

Mehdi Amini llvmlistbot at llvm.org
Wed Feb 14 18:35:09 PST 2024


================
@@ -875,7 +882,9 @@ ParseResult spirv::ExecutionModeOp::parse(OpAsmParser &parser,
     }
     values.push_back(llvm::cast<IntegerAttr>(value).getInt());
   }
-  result.addAttribute(kValuesAttrName,
+  StringRef valuesAttrName =
+      spirv::ExecutionModeOp::getValuesAttrName(result.name).strref();
----------------
joker-eph wrote:

StringRef still?

https://github.com/llvm/llvm-project/pull/81552


More information about the Mlir-commits mailing list