[Mlir-commits] [mlir] [mlir][Vectorizer] Added support to Vectorize tensor.unpack (PR #76087)

[llvmlistbot at llvm.org]

https://github.com/Max191 requested changes to this pull request.

Overall, looks good. I think we should try to support outer_dims_perm cases though. I added a comment describing how you can do that.

One of the tests looks wrong to me, although the logic for vectorization seems good to me. Maybe the test is incorrect?

Also, I think we can just use a zero constant as the padding_value for unpack. The padding_value should not show up in the result of the unpack, so it doesn't matter what value it is.

https://github.com/llvm/llvm-project/pull/76087