krzysz00 wrote: Overall, seems reasonable to me, though you'll want to stick the trivial "can this go through `mlir-opt`" test over in `mlir/test/Dialect/LLVMIR/rocdl.mlir` as well. https://github.com/llvm/llvm-project/pull/80888