[Mlir-commits] [mlir] [acc] Add attribute for combined constructs (PR #80319)

Razvan Lupusoru llvmlistbot at llvm.org
Fri Feb 2 12:09:09 PST 2024


================
@@ -1854,6 +1908,13 @@ LogicalResult acc::LoopOp::verify() {
           "reductions", false)))
     return failure();
 
+  if (getCombined().has_value() &&
+      (getCombined().value() != acc::CombinedConstructsType::ParallelLoop &&
+       getCombined().value() != acc::CombinedConstructsType::KernelsLoop &&
+       getCombined().value() != acc::CombinedConstructsType::SerialLoop)) {
----------------
razvanlupusoru wrote:

Not right now - but because the enum type is extensible, it made sense to be explicit about which ones are legal.

https://github.com/llvm/llvm-project/pull/80319


More information about the Mlir-commits mailing list