[Mlir-commits] [mlir] [acc] Add attribute for combined constructs (PR #80319)

[Razvan Lupusoru]

================
@@ -989,7 +1008,8 @@ def OpenACC_ParallelOp : OpenACC_Op<"parallel",
 
   let assemblyFormat = [{
     oilist(
-        `dataOperands` `(` $dataClauseOperands `:` type($dataClauseOperands) `)`
+        `combined` `(` custom<CombinedConstructs>($combined) `)`
----------------
razvanlupusoru wrote:

So I considered this at first - but dismissed this option. I preferred consistency in obtaining combined construct without any hidden semantics. This means one can query the compute and loop ops in an uniform manner and get the same attribute type value without having to do any additional interpretation.

And thus I extended the uniformity to the printing also - even though you are right that some information can be omitted.

https://github.com/llvm/llvm-project/pull/80319