[Mlir-commits] [mlir] [acc] Add attribute for combined constructs (PR #80319)

Valentin Clement バレンタイン クレメン llvmlistbot at llvm.org
Thu Feb 1 11:50:50 PST 2024


================
@@ -815,6 +815,11 @@ LogicalResult acc::ParallelOp::verify() {
   if (failed(checkWaitAndAsyncConflict<acc::ParallelOp>(*this)))
     return failure();
 
+  if (getCombined().has_value() &&
+      getCombined().value() != acc::CombinedConstructsType::ParallelLoop) {
----------------
clementval wrote:

nit: it the rest of the file we tend to use this form
```suggestion
  if (getCombined() && *getCombined() != acc::CombinedConstructsType::ParallelLoop) {
```

https://github.com/llvm/llvm-project/pull/80319


More information about the Mlir-commits mailing list