[Mlir-commits] [mlir] [mlir][sparse] Support pretty print to debug sparse iteration. (PR #80207)

Yinying Li llvmlistbot at llvm.org
Thu Feb 1 10:14:16 PST 2024


================
@@ -155,23 +171,31 @@ class SparseIterator {
   // Forwards the iterator to the next element.
   ValueRange forward(OpBuilder &b, Location l);
 
-  // Actual Implementation provided by derived class.
-  virtual void genInitImpl(OpBuilder &, Location, const SparseIterator *) = 0;
-  virtual ValueRange forwardImpl(OpBuilder &b, Location l) = 0;
+  // be done on an iterator that supports randm access.
----------------
yinying-lisa-li wrote:

Nit: capitalize first word.

https://github.com/llvm/llvm-project/pull/80207


More information about the Mlir-commits mailing list