[Mlir-commits] [mlir] [MLIR] Sprinkle extra asserts in OperationSupport.h (PR #90465)

Christian Ulmann llvmlistbot at llvm.org
Mon Apr 29 06:58:30 PDT 2024


================
@@ -1039,6 +1039,8 @@ struct OperationState {
 
   /// Add an attribute with the specified name.
   void addAttribute(StringAttr name, Attribute attr) {
----------------
Dinistro wrote:

Nit: Maybe consider to extend the, albeit limited documentation of these functions to incorporate these pre-conditions. 

https://github.com/llvm/llvm-project/pull/90465


More information about the Mlir-commits mailing list