[Mlir-commits] [mlir] [mlir][linalg] Enable fuse consumer (PR #89893)

[donald chen]

cxy-1993 wrote:

> Just adding this here as a proposal to consider if everyone thinks this would indeed be a better way forward :-
> 
> I believe having just the infra of `TilingInterface.td` + `TilingInterfaceImpl.cpp` (basically the reverted changes) as the separate base commit in the in-flight PR [88712](https://github.com/llvm/llvm-project/pull/88712) would be the most preferable way to go.
> 
> Reasons for the same :-
> 
> 1. The PR I added indeed makes use of the Interface methods to achieve the fusion for both scf.for and scf.forall.
> 2. The same PR also adds the necessary tests based on a test transform dialect op.
> 3. Most of the review comments by @ftynse  has already been addressed - so @cxy-1993 can avoid having to redo the same set of things here.
> 
> After [88712](https://github.com/llvm/llvm-project/pull/88712) lands the only set of actionable item left would be to define an official transform dialect that does the same job as the test transform dialect I've already added in my PR - something perhaps @cxy-1993 can take up thereafter.
> 
> This avoids any unnecessary code movements and makes it cleaner.

The proposal is also fine with me. Since @MaheshRavishankar @ftynse all agree  on this, I'll close this PR. Please cherry pick the interface part to your PR @Abhishek-Varma , thanks!

BTW, Thanks again to @ftynse  for reviewing this patch.

https://github.com/llvm/llvm-project/pull/89893