[Mlir-commits] [mlir] [MLIR][SCF] Add an API to fuse consumer to a producer within scf loop (PR #88712)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Fri Apr 19 14:35:22 PDT 2024


MaheshRavishankar wrote:

> Thank you @MaheshRavishankar @ftynse for your review comments! The one involving `OpOperand &` was extremely helpful and made the code super clean! Thank you.
> 
> I've addressed all your comments except the ones related to `TilingInterface.td` and `TilingInterfaceImpl.cpp` - since it is based of the [in-flight PR 88528](https://github.com/llvm/llvm-project/pull/85528) that will add these. Perhaps it's best handled there?
> 
> The major changes in the latest push in this PR are :-
> 
> 1. Add ability to deal with consumer yielding multiple values - previously I was constraining it to be a single yielding consumer. (You may check the new lit tests I've added).
> 2. I have updated all the assumptions with necessary checks and returning `failure()` in case it fails.
> 3. The newer algo mentioned [here](https://github.com/llvm/llvm-project/pull/88712#discussion_r1571929731).

Thanks @Abhishek-Varma  lets land this PR after https://github.com/llvm/llvm-project/pull/85528 lands.

https://github.com/llvm/llvm-project/pull/88712


More information about the Mlir-commits mailing list