[Mlir-commits] [mlir] [mlir][linalg] Add pass to transpose matmul op (PR #89075)

[Diego Caballero]

dcaballe wrote:

Not sure I follow the concern: is it about the pattern or the pass? I don't see any reason for the patterns to live downstream. Not sure I follow the one-off argument. We have plenty of patterns ranging from very simple to complex and collective transformations. The propose patterns are useful in general to transform an existing op into other existing ops and will include different variants (standard matmul, batch and even vecmat/matvec) so I don't see any kind of special casing here and do see applicability even beyond SME (e.g., in-place matmul transposes for a non-DT approach).

If the concern is about the pass, I guess we could turn the pass into a "test" pass and let users add these patterns to their downstream passes but, again, I think the pass is perfectly valid as it's doing a well defined set of transformations. We can also consider adding a TD op but I don't think we have been enforcing one alternative versus the other. Both options have been successfully co-existing and been added in a as-needed basis and I don't think there is a reason in this PR to follow a different approach.




https://github.com/llvm/llvm-project/pull/89075