[Mlir-commits] [mlir] [MLIR] Add single definition multiple regions for mem2reg (PR #89107)

[Christian Ulmann]

https://github.com/Dinistro requested changes to this pull request.

Thanks for your contribution. As you correctly observed, Mem2Reg does currently not support structured control flow, due to a lack of proper dominance analysis for CFGs with regions + interfaces to extend region holding operations with new values that need to flow into all successor regions. The latter would be required to promote values properly and let their results flow through registers (SSA values) instead of memory.

Unfortunately, this PR does only solve one specific special case, which is not something we strive for. If we want to support CFGs with regions, we need a principled approach that will require substantial extension to the existing algorithm.

May I ask what your use case for this specific special case is?

https://github.com/llvm/llvm-project/pull/89107