[Mlir-commits] [mlir] Enable printing newlines and indents in attribute and type printers (PR #87948)

Mehdi Amini llvmlistbot at llvm.org
Mon Apr 8 06:21:32 PDT 2024


joker-eph wrote:

Your PR description says "what" the commit is doing, but is not providing any motivation or context: can you elaborate on this? (see guidelines: https://mlir.llvm.org/getting_started/Contributing/#commit-messages )

Some of my questions will be about the composability: the operation is in control of the format in general, and having types randomly introducing new lines may not be actually composable.

https://github.com/llvm/llvm-project/pull/87948


More information about the Mlir-commits mailing list