[Mlir-commits] [mlir] [mlir][transform] Fix handling of transitive include in interpreter. (PR #67560)

Ingo Müller llvmlistbot at llvm.org
Fri Sep 29 03:07:03 PDT 2023


ingomueller-net wrote:

I think I changed my mind about the question of whether or not loading should be part of the interpreter. At the very least, I see that it is absolutely consistent to think of the current pass as "inject dependencies and interpret result." In this case, it is clear that running that pass twice in a way that tries to inject the dependencies twice does not work. The PR thus currently removes that test. If we decide that injection should be separated from the interpreter or that injection should be done only if necessary (such that it is idempotent), I believe we can do that in some future PR.

Other than that, I have overhauled the initial commit and think that it is ready for review now.

https://github.com/llvm/llvm-project/pull/67560


More information about the Mlir-commits mailing list