[Mlir-commits] [mlir] [mlir] Add loaded URI attribute type (PR #67276)

[Mehdi Amini]

joker-eph wrote:

> True, but I see almost nothing dialect specific here. Even today when we landed ArrayAttr, it could have been anywhere, but it mostly made sense here in an independent manner. Now we could have a file or uri dialect :)


I don't see it that way: `ArrayAttr` needed to be builtin because of things like "operand_segment_sizes": it is a fundamental building block (like an integer).  "loading a file" isn't in the same category to me (For example, look at programming language design: what is fundamental and what is "libraries"? You'll like find "integer" and "array of integer" as first-class constructs).


I have to digest the rest of your post, I don't quite grasp completely the "registry on the attribute" part right now (and also why wouldn't `file://` be just one registered handler)

https://github.com/llvm/llvm-project/pull/67276