[Mlir-commits] [mlir] [MLIR][LLVM] Add vararg support in LLVM::LLVMFuncOp (PR #67274)

Tobias Gysi llvmlistbot at llvm.org
Wed Sep 27 00:10:19 PDT 2023


================
@@ -297,9 +303,15 @@ convertOperationImpl(Operation &opInst, llvm::IRBuilderBase &builder,
           moduleTranslation.lookupBlock(invOp.getSuccessor(0)),
           moduleTranslation.lookupBlock(invOp.getSuccessor(1)), operandsRef);
     } else {
+      llvm::FunctionType *calleeType;
+      if (invOp.getCalleeType().has_value())
----------------
gysit wrote:

```suggestion
      if (invOp.getCalleeType())
```
nit: has_value should not be necessary.

https://github.com/llvm/llvm-project/pull/67274


More information about the Mlir-commits mailing list