[Mlir-commits] [mlir] [MLIR][LLVM] Add vararg support in LLVM::LLVMFuncOp (PR #67274)

Tobias Gysi llvmlistbot at llvm.org
Wed Sep 27 00:10:18 PDT 2023


================
@@ -1018,6 +1018,27 @@ static void printStoreType(OpAsmPrinter &printer, Operation *op,
 // CallOp
 //===----------------------------------------------------------------------===//
 
+/// Get the MLIR Op-like result types of a LLVMFunctionType
----------------
gysit wrote:

```suggestion
/// Gets the MLIR Op-like result types of a LLVMFunctionType.
```
nit: All comments should end with a dot and the comments should use third person singular for the verb (Get -> Gets). Would it make sense to rename the function to getCallOpResultTypes since it returns a type array?

https://github.com/llvm/llvm-project/pull/67274


More information about the Mlir-commits mailing list