[Mlir-commits] [mlir] Don't use LLVM_TABLEGEN_FLAGS with mlir-pdll: it's not a TableGen tool (PR #67486)

[Mehdi Amini]

https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/67486

This can lead to build failure when a project is customizing this flag for TableGen. This seems to have been copy/pasted from TableGen CMake functions.

>From 1f1ecd8007e7552d96f2d8651b292dc2acc4489b Mon Sep 17 00:00:00 2001
From: Mehdi Amini <joker.eph at gmail.com>
Date: Tue, 26 Sep 2023 13:32:27 -0700
Subject: [PATCH] Don't use LLVM_TABLEGEN_FLAGS with mlir-pdll: it's not a
 TableGen tool

This can lead to build failure when a project is customizing this flag for
TableGen. This seems to have been copy/pasted from TableGen CMake functions.
---
 mlir/cmake/modules/AddMLIR.cmake | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mlir/cmake/modules/AddMLIR.cmake b/mlir/cmake/modules/AddMLIR.cmake
index 6acb01c305ad025..4622d4d05fcbdeb 100644
--- a/mlir/cmake/modules/AddMLIR.cmake
+++ b/mlir/cmake/modules/AddMLIR.cmake
@@ -108,7 +108,6 @@ function(_pdll_tablegen project ofn)
   add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${ofn}
     COMMAND ${tablegen_exe} ${ARG_UNPARSED_ARGUMENTS} -I ${CMAKE_CURRENT_SOURCE_DIR}
     ${tblgen_includes}
-    ${LLVM_TABLEGEN_FLAGS}
     ${LLVM_TARGET_DEFINITIONS_ABSOLUTE}
     ${tblgen_change_flag}
     ${additional_cmdline}