[Mlir-commits] [mlir] [MLIR][LLVM] Add vararg support in LLVM::LLVMFuncOp (PR #67274)

Christian Ulmann llvmlistbot at llvm.org
Tue Sep 26 00:07:22 PDT 2023


================
@@ -1301,14 +1378,51 @@ ParseResult CallOp::parse(OpAsmParser &parser, OperationState &result) {
       parser.parseOptionalAttrDict(result.attributes))
     return failure();
 
+  bool isVarArg = parser.parseOptionalKeyword("vararg").succeeded();
+  if (isVarArg) {
+    if (parser.parseLParen().failed() ||
----------------
Dinistro wrote:

NIT: `.failed()` shouldn't be the necessary here, as the result type is implicitly convertible to `bool`.  

https://github.com/llvm/llvm-project/pull/67274


More information about the Mlir-commits mailing list