[Mlir-commits] [mlir] [MLIR] When generating tests explicitly match only valid SSA var names (PR #67279)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Mon Sep 25 00:51:31 PDT 2023


================
@@ -180,7 +180,7 @@ def process_line(line_chunks, variable_namer):
         else:
             # Otherwise, generate a new variable.
             variable = variable_namer.generate_name(ssa_name)
-            output_line += "%[[" + variable + ":.*]]"
+            output_line += "%[[" + variable + ":" + SSA_RE_STR + "]]"
----------------
ftynse wrote:

This would make the directive obnoxiously long. Are you hitting a lot of cases where `.*` matches too much?

Note that this script is intended to produce an initial version of the test and some manual editing is expected.

https://github.com/llvm/llvm-project/pull/67279


More information about the Mlir-commits mailing list