[Mlir-commits] [mlir] [mlir][gpu] Add a symbol table field to TargetOptions and adjust GpuModuleToBinary (PR #65797)

Mehdi Amini llvmlistbot at llvm.org
Sat Sep 9 14:32:25 PDT 2023


================
@@ -56,10 +57,11 @@ class TargetOptions {
 
   /// Constructor initializing the toolkit path, the list of files to link to,
   /// extra command line options & the compilation target. The default
-  /// compilation target is `binary`.
+  /// compilation target is `binOrFatbin`.
   TargetOptions(StringRef toolkitPath = {},
                 ArrayRef<std::string> linkFiles = {}, StringRef cmdOptions = {},
-                CompilationTarget compilationTarget = binOrFatbin);
+                CompilationTarget compilationTarget = binOrFatbin,
+                function_ref<SymbolTable *()> symbolTableCallback = {});
----------------
joker-eph wrote:

I'd call it `getSymbolTable` (or `getSymbolTableCallback` if you want to include `callback` in the name) to keep a verb here.

https://github.com/llvm/llvm-project/pull/65797


More information about the Mlir-commits mailing list