gysit wrote: One last comment. You may want to do add a short roundtrip test to test printing and parsing, similar to this one: https://github.com/llvm/llvm-project/blob/8be07adfb42d8d5d060b807d5445b6fefc949bee/mlir/test/Dialect/LLVMIR/roundtrip.mlir#L333 https://github.com/llvm/llvm-project/pull/65508