[Mlir-commits] [mlir] [mlir][llvm] Add zeroinitializer constant (PR #65508)

[Tobias Gysi]

https://github.com/gysit commented:

Thanks for the very thorough testing!

I would nevertheless suggest to reduce the test set a bit :). After removing the typed pointers some tests will not have a lot of value (e.g. the function pointer test). Additionally, you do not need to check every type in the context of a global and in the context of a function.

After all we are mostly testing an LLVM function (if I understand correctly):
`llvm::Constant::getNullValue($_resultType)`
plus the type conversion applied to convert the result type. This type conversion should already be tested though. 

I would suggest to keep some tests with global variables and some tests in the context of the function and using different types for all of them. Having some more complex aggregate type for sure is nice as well.

https://github.com/llvm/llvm-project/pull/65508