[Mlir-commits] [mlir] [mlir][llvm] Return failure from type converter for n-D scalable vectors (PR #65450)

Cullen Rhodes llvmlistbot at llvm.org
Wed Sep 6 05:49:23 PDT 2023


c-rhodes wrote:

> ATM, we only use 1. I am guessing that you'd like to use 2. for `vector.outerproduct` to lower to SME's MOPA instructions, e.g. [FMOPA](https://developer.arm.com/documentation/ddi0602/2021-06/SME-Instructions/FMOPA--non-widening---Floating-point-outer-product-and-accumulate-)? I am still wondering whether mixing 1. and 2. is the right approach.
> 
> But that's something we can discuss in a different patch,, this change makes sense regardless.

That's correct, I want to lower `vector.outerproduct` directly to intrinsics, at least initially as this seems to work. But this would also open this up for other ops where possible.

> 
> LGTM, but please wait for more reviews before landing this :)

Thanks for reviewing!

https://github.com/llvm/llvm-project/pull/65450


More information about the Mlir-commits mailing list