[Mlir-commits] [mlir] [mlir][llvm] Return failure from type converter for n-D scalable vectors (PR #65450)

[Andrzej Warzyński]

banach-space wrote:

Thank you, this is far less intrusive and feels much more canonical than https://github.com/llvm/llvm-project/pull/65261 - this would be my preference :)

This should be sufficient for two types of lowerings from `Vector` to `ArmSME`:
1. Vector -> ArmSME Ops -> LLVM SME intrinsics (_with_ custom ops),
2. Vector -> LLVM SME intrinsics (_without_ custom ops).

ATM, we only use 1. I am guessing that you'd like to use 2. for `vector.outerproduct` to lower to SME's MOPA instructions, e.g. [FMOPA](https://developer.arm.com/documentation/ddi0602/2021-06/SME-Instructions/FMOPA--non-widening---Floating-point-outer-product-and-accumulate-)? I am still wondering whether mixing 1. and 2. is the right approach.

But that's something we can discuss in a different patch,, this change makes sense regardless.

LGTM, but please wait for more reviews before landing this :)

https://github.com/llvm/llvm-project/pull/65450