[Mlir-commits] [mlir] Switch MLIR to use the internal LIT shell by default (PR #65415)

[Mehdi Amini]

================
@@ -18,7 +18,14 @@
 # name: The name of this test suite.
 config.name = "MLIR"
 
-config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell)
+# We prefer the lit internal shell which provide a better user experience on failures
+# Unless the user explicitly disable it with LIT_USE_INTERNAL_SHELL=0 env var.
+use_lit_shell = True
+lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
+if lit_shell_env:
+  use_lit_shell = not lit.util.pythonize_bool(lit_shell_env)
+
+config.test_format = lit.formats.ShTest(execute_external=not use_lit_shell)
----------------
joker-eph wrote:

Actually I misremembered, it is controlled by the env var always...

Something to note is that we will still have `features.add("shell")` added by lit already here.


https://github.com/llvm/llvm-project/pull/65415