[Mlir-commits] [mlir] [mlir][arith] Add ArithOpsInterfaces to mlir-generic-headers (PR #70862)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Oct 31 14:38:56 PDT 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-arith

Author: None (anemet)

<details>
<summary>Changes</summary>

This is achieved by calling add_mlir_interface.

The issue manifests as ArithOpsInterfaces.h.inc not being available when a pass includes something like MemRef.h which includes Arith.h.

Tested with check-mlir.

---
Full diff: https://github.com/llvm/llvm-project/pull/70862.diff


1 Files Affected:

- (modified) mlir/include/mlir/Dialect/Arith/IR/CMakeLists.txt (+1-5) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/Arith/IR/CMakeLists.txt b/mlir/include/mlir/Dialect/Arith/IR/CMakeLists.txt
index 5cdde2edd50f1ea..a2f24bdd94444db 100644
--- a/mlir/include/mlir/Dialect/Arith/IR/CMakeLists.txt
+++ b/mlir/include/mlir/Dialect/Arith/IR/CMakeLists.txt
@@ -7,8 +7,4 @@ mlir_tablegen(ArithOpsAttributes.cpp.inc -gen-attrdef-defs
               -attrdefs-dialect=arith)
 add_mlir_dialect(ArithOps arith)
 add_mlir_doc(ArithOps ArithOps Dialects/ -gen-dialect-doc)
-
-set(LLVM_TARGET_DEFINITIONS ArithOpsInterfaces.td)
-mlir_tablegen(ArithOpsInterfaces.h.inc -gen-op-interface-decls)
-mlir_tablegen(ArithOpsInterfaces.cpp.inc -gen-op-interface-defs)
-add_public_tablegen_target(MLIRArithOpsInterfacesIncGen)
+add_mlir_interface(ArithOpsInterfaces)

``````````

</details>


https://github.com/llvm/llvm-project/pull/70862


More information about the Mlir-commits mailing list