[Mlir-commits] [mlir] [mlir][SCF] Use `transform.get_parent_op` instead of `transform.loop.get_parent_for` (PR #70757)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Oct 30 19:20:12 PDT 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r e6971e5a41fe30264af9a13c8f387c06f93c6d9c..9e53fbed47cde1cccefec45815246ec8baa1c2da mlir/python/mlir/dialects/transform/__init__.py mlir/python/mlir/dialects/transform/loop.py mlir/test/python/dialects/transform.py mlir/test/python/dialects/transform_loop_ext.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- python/mlir/dialects/transform/__init__.py	2023-10-31 02:17:32.000000 +0000
+++ python/mlir/dialects/transform/__init__.py	2023-10-31 02:20:05.326149 +0000
@@ -50,33 +50,32 @@
         return self.regions[0].blocks[0]
 
 
 @_ods_cext.register_operation(_Dialect, replace=True)
 class GetParentOp(GetParentOp):
-
-  def __init__(
-      self,
-      result_type: Type,
-      target: Union[Operation, Value],
-      *,
-      isolated_from_above: bool = False,
-      op_name: Optional[str] = None,
-      deduplicate: bool = False,
-      nth_parent: int = 1,
-      loc=None,
-      ip=None,
-  ):
-    super().__init__(
-        result_type,
-        _get_op_result_or_value(target),
-        isolated_from_above=isolated_from_above,
-        op_name=op_name,
-        deduplicate=deduplicate,
-        nth_parent=nth_parent,
-        loc=loc,
-        ip=ip,
-    )
+    def __init__(
+        self,
+        result_type: Type,
+        target: Union[Operation, Value],
+        *,
+        isolated_from_above: bool = False,
+        op_name: Optional[str] = None,
+        deduplicate: bool = False,
+        nth_parent: int = 1,
+        loc=None,
+        ip=None,
+    ):
+        super().__init__(
+            result_type,
+            _get_op_result_or_value(target),
+            isolated_from_above=isolated_from_above,
+            op_name=op_name,
+            deduplicate=deduplicate,
+            nth_parent=nth_parent,
+            loc=loc,
+            ip=ip,
+        )
 
 
 @_ods_cext.register_operation(_Dialect, replace=True)
 class MergeHandlesOp(MergeHandlesOp):
     def __init__(
--- test/python/dialects/transform.py	2023-10-31 02:17:32.000000 +0000
+++ test/python/dialects/transform.py	2023-10-31 02:20:05.430139 +0000
@@ -155,25 +155,25 @@
   # CHECK: }
 
 
 @run
 def testGetParentOp():
-  sequence = transform.SequenceOp(
-      transform.FailurePropagationMode.Propagate, [], transform.AnyOpType.get()
-  )
-  with InsertionPoint(sequence.body):
-    transform.GetParentOp(
-        transform.AnyOpType.get(),
-        sequence.bodyTarget,
-        isolated_from_above=True,
-        nth_parent=2,
-    )
-    transform.YieldOp()
-  # CHECK-LABEL: TEST: testGetParentOp
-  # CHECK: transform.sequence
-  # CHECK: ^{{.*}}(%[[ARG1:.+]]: !transform.any_op):
-  # CHECK:   = get_parent_op %[[ARG1]] {isolated_from_above, nth_parent = 2 : i64}
+    sequence = transform.SequenceOp(
+        transform.FailurePropagationMode.Propagate, [], transform.AnyOpType.get()
+    )
+    with InsertionPoint(sequence.body):
+        transform.GetParentOp(
+            transform.AnyOpType.get(),
+            sequence.bodyTarget,
+            isolated_from_above=True,
+            nth_parent=2,
+        )
+        transform.YieldOp()
+    # CHECK-LABEL: TEST: testGetParentOp
+    # CHECK: transform.sequence
+    # CHECK: ^{{.*}}(%[[ARG1:.+]]: !transform.any_op):
+    # CHECK:   = get_parent_op %[[ARG1]] {isolated_from_above, nth_parent = 2 : i64}
 
 
 @run
 def testMergeHandlesOp():
     sequence = transform.SequenceOp(

``````````

</details>


https://github.com/llvm/llvm-project/pull/70757


More information about the Mlir-commits mailing list